[hotfix] [docs] Update overview.md with link to dependencies#27366
[hotfix] [docs] Update overview.md with link to dependencies#27366ZDevelop94 wants to merge 1 commit intoapache:release-1.14from
Conversation
It took an extended amount of time to find the needed dependencies to compile the code and shouldn't be hidden on the last page of the Datastream API section.
| The following program is a complete, working example of streaming window word count application, that counts the | ||
| words coming from a web socket in 5 second windows. You can copy & paste the code to run it locally. | ||
|
|
||
| Find dependencies needed to run code here https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/datastream/project-configuration/. |
There was a problem hiding this comment.
Please recommend more dynamic url not tied to version number
github-actions
bot
added
target:release-1.14
community-reviewed
| The following program is a complete, working example of streaming window word count application, that counts the | ||
| words coming from a web socket in 5 second windows. You can copy & paste the code to run it locally. | ||
|
|
||
| Find dependencies needed to run code here https://nightlies.apache.org/flink/flink-docs-release-1.14/docs/dev/datastream/project-configuration/. |
There was a problem hiding this comment.
why is this targeted to a very old Flink release. I would expect changes to go into master and be backported to the supported versions.
There was a problem hiding this comment.
@davidradl @snuyanzin It was raised here as I was looking at this release version at the time and posed an example, hence why I suggested a more dynamic url to address other release versions. Once this is done I can revert the target branch to main
There was a problem hiding this comment.
@ZDevelop94 We do not support 1.14, so would not be merging changes to 1.14. I suggest a new PR be raised on master or one of the supported versions as @snuyanzin advised. If you need to discuss this first then please use the Flink dev list. fyi I notice that https://nightlies.apache.org/flink/flink-docs-stable/docs/dev/datastream/project-configuration/ does not exist at the latest release Flink version.
|
@ZDevelop94 is there a reason you've submitted a PR against 1.14? 1.14 is not supported for a long time, so I don't see a reason for this PR. |
4 participants
What is the purpose of the change
It took way too long to find the needed dependencies to compile the code and shouldn't be hidden on the page of the Datastream API section.
Brief change log
Added a link to dependencies to the first page where developers that want to start quickly expect to see it and shouldn't have to go digging.
Verifying this change
No change, just documentation
Documentation